-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Enhancement Add max_level param to json_normalize #26876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement Add max_level param to json_normalize #26876
Conversation
max_level param defines at the level of nesting at which normalizing should stop. ignore_keys defines the keys to ignore without normalizing
…_records_path_bug_fix
…nced_json_normalize
…ncement/max_level_to_json_normalize
…ncement/max_level_to_json_normalize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls merge master as well
code & tests look good, can you add a note in whatsnew (other enhancements); also consider if we should update the docs in io.rst (adding an example using max_level) |
@jreback I assumed docstrings would generate the docs in pandas/doc folder, now I am anticipating that's not right. So should we manually add it with the ipython constructs? |
I am requesting an entry in doc/source/whatsnew/v0.25.0.txt & any updates in io.rst that are needed |
Looks like a remaining lint error but otherwise lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks for sticking through review
My pleasure. I learned alot along the way. Thank you for being so patient with me. |
Thanks @bhavaniravi! |
git diff upstream/master -u -- "*.py" | flake8 --diff